fix: revert "fix(iOS): proper layout calculation #339"#417
Open
szydlovsky wants to merge 1 commit intomainfrom
Open
fix: revert "fix(iOS): proper layout calculation #339"#417szydlovsky wants to merge 1 commit intomainfrom
szydlovsky wants to merge 1 commit intomainfrom
Conversation
kacperzolkiewski
approved these changes
Feb 13, 2026
Contributor
|
@szydlovsky Could you give more context on what goes wrong?
NOTE: If you revert these changes, then please test this flow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #339 due to a iOS layout bug we found;
The input sometimes becomes unscrollable when it's inside a scrollable bottom sheet (
@gorhom/bottom-sheet), with aKeyboardAwareScrollView(react-native-keyboard-controller) turned into a proper bottom-sheet-scrollview component.The bug doesn't appear when testing a commit before the PR, but does happen on the exact merge commit of the said PR.