Skip to content

fix: revert "fix(iOS): proper layout calculation #339"#417

Open
szydlovsky wants to merge 1 commit intomainfrom
@szydlovsky/reverse-ios-layout-calculation-pr
Open

fix: revert "fix(iOS): proper layout calculation #339"#417
szydlovsky wants to merge 1 commit intomainfrom
@szydlovsky/reverse-ios-layout-calculation-pr

Conversation

@szydlovsky
Copy link
Collaborator

@szydlovsky szydlovsky commented Feb 13, 2026

Reverts #339 due to a iOS layout bug we found;
The input sometimes becomes unscrollable when it's inside a scrollable bottom sheet (@gorhom/bottom-sheet), with a KeyboardAwareScrollView (react-native-keyboard-controller) turned into a proper bottom-sheet-scrollview component.

The bug doesn't appear when testing a commit before the PR, but does happen on the exact merge commit of the said PR.

@IvanIhnatsiuk
Copy link
Contributor

@szydlovsky Could you give more context on what goes wrong?

  1. Is it full height input placed in the bottom sheet scroll view? If so, then the scroll breaks because it renders a UIScrollView inside another UIScrollView. Have you tried to give an exact height for one of these scroll views?
  2. Could you check the layout in iOS native hierarchy and try to get the layout height value of the input?

NOTE: If you revert these changes, then please test this flow:

  1. Open screen A with the enriched input
  2. Type any text to make it scrollable and scroll to the end of the
  3. Navigate to screen B
  4. Navigate back to screen A and check the scroll position

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants