Skip to content

Conversation

@j-piasecki
Copy link
Member

Description

Our check for ScrollView was checking for RCTScrollViewComponentView, but inside NativeDetector, we extract contentView from RCTViewComponentViews:

if ([view isKindOfClass:[RCTViewComponentView class]]) {
RCTViewComponentView *componentView = (RCTViewComponentView *)view;
if (componentView.contentView != nil) {
view = componentView.contentView;
}
}

And it so happens that RCTScrollViewComponentView inherits from RCTViewComponentView, which broke the ScrollView detection. The contentView of RCTScrollViewComponentView is RCTEnhancedScrollView.

Test plan

ScrollView from RNGH should now correctly delay touches on native buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants