Repository navigation
feat(docs): give the site the two-level sidebar and the new page tree - #20
Merged
Merged
Conversation
kligarski
reviewed
Oct 13, 2026
kligarski
left a comment
Member
There was a problem hiding this comment.
- I really don't like that "React Common Types" is a link but other same-level headings in the sidebar are not links. I'm wondering if artifically adding a subpage wouldn't be better:
React Common Types
- Types
or something like this.
-
Nit: "overview" placeholder for Core Components/Modals looks odd. Let's maybe add placeholders for some of the real components instead. You can also add placeholders for stack and split in core containers section.
-
In-page navigation is a bit awkward still but I'm guessing that this will be handled separately with other page layout PR.
Loloekk
force-pushed
the
@Loloekk/08-platform-props
branch
from
October 19, 2026 16:14
717a10a to
4894356
Compare
Loloekk
force-pushed
the
@Loloekk/09-sidebar-two-levels
branch
from
October 19, 2026 16:14
66fa5da to
1be9989
Compare
Contributor
Author
|
Loloekk
force-pushed
the
@Loloekk/09-sidebar-two-levels
branch
from
October 19, 2026 16:46
1ff3982 to
5cff1e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Puts the generated family pages into the sidebar and replaces the old hand-written tree.
React Common Types · Core Containers · Core Components & Modals · Guides · Meta. A family
(Stack, Tabs, …) is one page; its table of contents is the in-page navigation.
.sidebar-section-link): itshares the section labels' font rule in
typography.css, and its spacing comes fromt-rex-ui's label and section-list margins (named variables, with the mobile value), so the
gaps between all sections are equal.
*-emptyuntil they get content or be removed. Introduction keeps
slug: /, so/docs/still resolves.move into Meta → Contributing as its "Documentation guidelines" and "MDX components"
sections; only headings and links were adjusted.
docs/components,docs/navigators,docs/experimental,docs/react-navigation,docs/contributing, the old Fundamentals and Guides pages, and the two sidebar CSS rulesonly they used.
Known: stub pages still carry
-emptyin their URLs (e.g./docs/fundamentals/getting-started-empty); to be changed separately.Test plan
yarn buildpasses locallyhttp://localhost:3000/react-native-screens/Screenshots