Conversation
…sport for handling deduplications on client side #KOJAK-78
rawo
requested review from
endrju19 and
ramafasa
and
a lite review from Copilot
September 25, 2026 13:48
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Documentation should clarify built-in transport scope and safe deduplication handling.
Review effort: Lite
Findings: None
What changed in this PR
Adds stable x-outbox-id headers to Kafka and HTTP deliveries for consumer-side deduplication.
Changes:
- Adds the shared
OutboxHeaders.OUTBOX_IDconstant. - Injects UUIDs into Kafka and HTTP deliveries, including batches.
- Adds documentation, changelog, unit tests, and integration coverage.
| File | Summary |
|---|---|
README.md |
Documents header usage and deduplication |
okapi-kafka/src/test/kotlin/com/softwaremill/okapi/kafka/KafkaMessageDelivererTest.kt |
Tests Kafka header behavior |
okapi-kafka/src/main/kotlin/com/softwaremill/okapi/kafka/KafkaMessageDeliverer.kt |
Adds headers to Kafka records |
okapi-integration-tests/src/test/kotlin/com/softwaremill/okapi/test/transport/KafkaTransportIntegrationTest.kt |
Verifies broker delivery and retry stability |
okapi-http/src/test/kotlin/com/softwaremill/okapi/http/HttpMessageDelivererTest.kt |
Tests HTTP header behavior |
okapi-http/src/main/kotlin/com/softwaremill/okapi/http/HttpMessageDeliverer.kt |
Adds headers to HTTP requests |
okapi-core/src/main/kotlin/com/softwaremill/okapi/core/OutboxHeaders.kt |
Defines the shared header constant |
CHANGELOG.md |
Records the new delivery header |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ramafasa
approved these changes
Sep 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an x-outbox-id header carrying the outbox entry's UUID to every delivery, giving consumers a stable key to deduplicate redeliveries on. Part 1 of KOJAK-78 only — the shutdown-timeout change is not in this PR.
Changes
Note: the ticket's snippet used entry.outboxId.value; the value class field is raw.
Tests (+7)
Test plan
#KOJAK-78