refactor(traits): add PdaAccount trait for accounts storing bump #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces PdaAccount extension trait that provides convenience methods for account types that store their PDA bump. Implements the trait for Escrow and Receipt, allowing them to use validate_self() instead of manually passing the bump to validate_pda(). This matches the pattern established in the rewards program and improves type-level semantics by distinguishing "seed containers" from "actual PDA accounts".
amilz
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PdaAccountextension trait that provides convenience methods for account types storing their PDA bumpPdaAccountforEscrowandReceipt, enabling use ofvalidate_self()instead of manually passing bump tovalidate_pda()Test Plan
All existing unit tests pass:
cargo test -p escrow-program132 tests pass, including 3 new tests for the
PdaAccounttrait:test_pda_account_bump- verifies bump accessortest_pda_account_inherits_pda_seeds- confirms trait inheritancetest_pda_account_derive_address- validates PDA derivation