-
Notifications
You must be signed in to change notification settings - Fork 39
use bpf stake #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use bpf stake #424
Conversation
|
alright this is now required work for solana-program/stake#240. it might be easier to get it working on a 1sol bpf program first though, and work backwards for some 1lamp coverage, since i assume the test breakage is because we were only testing 1sol min |
|
cc @joncinque, this isnt ready to merge since:
but it is encouraging confirmation that stake pool handles the 1sol minimum in bpf stake correctly as-is |
|
Ok that's great! Let me know if you need me to take anything over on this side |
|
ok with dev machine, and compiled binaries so i can with my binary, which is latest commit to stake program latest including 1 sol minimum delegation (importantly meaning we also test stake pool against all the previous big commits like split rewrite, realloc to zero, and new interface) the only failures are the hijack tests. ill pare one down to a "hijack isnt possible" test and delete the rest with a release stake program binary, we also have these failures: meaning there are assumptions in these stake pool tests that depend on a 1sol minimum delegation, since tests in master only run with the feature on. i havent fully diagnosed yet but it might be setup issues confusing |
|
the committed binary was from my branch but shasums identical to one built off stake program master ( |
joncinque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for handling this! Thanks also for outlining all the failing tests, I tested them against the old and new programs, and #557 should fix everything
we can do the stake history thing a bit cleaner this is just a demo...
decrease.rsandwithdraw_with_fee.rsstill fail for reasons i havent identified yet (possibly others, the full stake pool test gauntlet is heavy for my laptop so i get meaningless failures when trying to run all the files even with--test-threads 1)