Skip to content

Feat/my school email verification#570

Merged
yoonc01 merged 5 commits into
mainfrom
feat/my-school-email-verification
Jun 22, 2026
Merged

Feat/my school email verification#570
yoonc01 merged 5 commits into
mainfrom
feat/my-school-email-verification

Conversation

@yoonc01

@yoonc01 yoonc01 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

작업 내용

마이페이지에서 학교 이메일 인증을 가능하게 했습니다.

@yoonc01 yoonc01 self-assigned this Jun 22, 2026
@vercel

vercel Bot commented Jun 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Error Error Jun 22, 2026 3:53pm
solid-connection-web Ready Ready Preview, Comment Jun 22, 2026 3:53pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Jun 22, 2026 3:53pm

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@yoonc01, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 49 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b9b36eb7-1235-4199-b342-4adbe0bc70a4

📥 Commits

Reviewing files that changed from the base of the PR and between e0343a2 and cbf357a.

📒 Files selected for processing (1)
  • apps/web/src/apis/MyPage/postConfirmSchoolEmail.ts

Walkthrough

  1. 타입 및 API 계약 추가

    • BaseUserInfohomeUniversityName: string | null 필드가 추가되었습니다.
    • SchoolEmailPostRequest, SchoolEmailConfirmPostRequest DTO 인터페이스 2개가 새로 정의되었습니다.
    • myPageApi/my/school-email/my/school-email/confirm 엔드포인트로 POST하는 메서드 2개가 추가되었습니다.
    • QueryKeys.MyPage.schoolEmail 쿼리 키 상수가 추가되었습니다.
  2. React Query 뮤테이션 훅 구현

    • usePostSchoolEmail, usePostConfirmSchoolEmail 훅이 신규 파일로 추가되었습니다.
    • usePostConfirmSchoolEmail은 성공 시 토큰 재발급 후 프로필 쿼리를 무효화합니다.
    • 두 훅 모두 전역 에러 토스트를 건너뛰도록 설정되었습니다.
  3. 학교 이메일 인증 UI

    • email → code → done 3단계 흐름의 SchoolEmailVerificationContent 컴포넌트가 신규 구현되었습니다.
    • 300초 타이머, 숫자 6자리 입력 제한, homeUniversityName 기반 자동 완료 전환이 포함됩니다.
  4. 페이지 및 진입점 연결

    • /my/school-email Next.js 페이지가 추가되었으며 noindex 메타데이터가 설정되었습니다.
    • MyProfileContent "계정 관리" 섹션에 학교 인증 링크 항목이 추가되었습니다.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • wibaek
  • enunsnv
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning 작업 내용은 간단히 기술되었으나, 관련 이슈, 특이 사항, 리뷰 요구사항 등 필수 섹션이 누락되어 있어 템플릿 기준으로 부족합니다. 관련 이슈 번호, 특이 사항(타이머 검증 로직, 토큰 새로고침 등), 리뷰 중점 사항 등을 추가로 작성해주세요.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 학교 이메일 인증 기능이라는 주요 변경 사항을 명확하게 반영하고 있으며, 추가된 API, 훅, UI 컴포넌트 등 전체 작업을 잘 대표합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/my-school-email-verification

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0343a20dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/apis/MyPage/postConfirmSchoolEmail.ts Outdated
@yoonc01 yoonc01 removed the admin label Jun 22, 2026
@vercel vercel Bot temporarily deployed to Preview – solid-connect-web-admin June 22, 2026 15:51 Inactive
@github-actions github-actions Bot added the admin label Jun 22, 2026
@yoonc01 yoonc01 merged commit 942f35d into main Jun 22, 2026
12 of 13 checks passed
@yoonc01 yoonc01 deleted the feat/my-school-email-verification branch June 22, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant