Skip to content

Fix 404 error#1549

Merged
LadyBluenotes merged 7 commits into
solidjs:mainfrom
amirhhashemi:fix-404-err
Jun 21, 2026
Merged

Fix 404 error#1549
LadyBluenotes merged 7 commits into
solidjs:mainfrom
amirhhashemi:fix-404-err

Conversation

@amirhhashemi

@amirhhashemi amirhhashemi commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes two 404 errors that happened for different reasons.

#1524: The <ImageLinks> component was not defined properly. I think it was created during the transaction to the osmium theme. I'm not familiar with that theme and not sure if that's a bug on their side. The most reasonable fix was to move it to the osmium/src/ui/image-link.tsx file and export it from the mdx-components.ts file.
#1546 and #1472: We don't have a warning callout. Changed it to caution.

Closes #1546
Closes #1524
Closes #1472

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify

netlify Bot commented Jun 20, 2026

Copy link
Copy Markdown

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 8e25c86
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6a376a34f001a30008ee5081
😎 Deploy Preview https://deploy-preview-1549--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@LadyBluenotes LadyBluenotes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page "deploying your own app" is broken because it imports the following:

import { ImageLink } from "~/components/ImageLink";

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) June 21, 2026 04:36
@LadyBluenotes LadyBluenotes merged commit 07601f0 into solidjs:main Jun 21, 2026
7 of 8 checks passed
@amirhhashemi amirhhashemi deleted the fix-404-err branch June 21, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants