Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 58e2d41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tomheaton
force-pushed
the
fix/null-history-state-depth
branch
from
October 15, 2026 08:14
05df79a to
58e2d41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saveCurrentDepth()runs on import and readswindow.history.state._depthright afterreplaceState. In an iOS WKWebView (a Flutterflutter_inappwebviewembed in our case)replaceStatedoesn't throw buthistory.statestaysnull, so importing the router throws:Because it happens at module eval, the whole app bundle fails to load, even when only
MemoryRouteris used.This falls back to
history.length - 1, the same value it tries to write. Nothing changes whenhistory.stateworks.Added a test that mocks
history.stateas null andreplaceStateas a no-op. It fails without the fix.Same fix for
next: #627