Repository navigation
fix(query): keep parsed search data stable during navigation - #635
Merged
Merged
Conversation
Track the search string when parsing location.query so pathname and hash changes do not invalidate query consumers or recreate repeated values. Cover enumeration, queryWrapper, search changes and history navigation.
🦋 Changeset detectedLatest commit: 6e47fbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #624.
Moving from
/one?tag=a&tag=bto/two?tag=a&tag=bused to rebuild the parsed query. Components that spread or enumeratelocation.queryreran, andtagbecame a new array even though the search string had not changed.Query parsing now tracks the search string. Pathname and hash changes keep the existing data; changing the search still updates consumers. The public query proxy and
queryWrapperAPI stay the same.Tests cover enumeration, repeated parameters,
queryWrapper, and back/forward navigation.Validation:
pnpm test: 445 client tests, 38 server tests and the test typecheck pass.routing.tsandsearch-params.spec.tsxare unchanged.git diff --checkpasses.