chore: update Solid Router to v1 - #2264
Merged
Merged
Conversation
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
birkskyum
marked this pull request as ready for review
July 28, 2026 23:29
brenelz
approved these changes
Jul 28, 2026
birkskyum
marked this pull request as draft
July 28, 2026 23:30
brenelz
reviewed
Jul 28, 2026
birkskyum
marked this pull request as ready for review
July 28, 2026 23:32
brenelz
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@solidjs/router@^1.0.0@solidjs/start's existing optional Router peer to v1 without adding a direct or development dependency1.0.0through the workspace's minimum-release-age policySolid Router v1 is API-compatible with the router APIs used in this repository, so no source migration is needed. This makes all workspace consumers resolve Router
1.0.0instead of0.16.2.No changeset is included because the published
@solidjs/startdependency contract is unchanged.Validation
pnpm install --frozen-lockfilepnpm format:checkpnpm buildpnpm --filter './apps/**' --recursive run buildpnpm --filter tests run unit:ci(5 tests)pnpm --filter @solidjs/start run test:ci(88 tests)