fix(deps): bump multistore to the non-S3 streaming-upload guard#166
Closed
alukach wants to merge 1 commit into
Closed
fix(deps): bump multistore to the non-S3 streaming-upload guard#166alukach wants to merge 1 commit into
alukach wants to merge 1 commit into
Conversation
main pins the multistore aws-chunked branch at 71b1513a (the original stream-resign commit). Bump to 71e51edd, which adds a 4-agent-review fix: a default aws-chunked PUT to a non-S3 backend (azure) was mis-routing into the S3-only seed-signing path instead of being rejected. Also drops a dead re-read and adds regression tests. multistore PR: developmentseed/multistore#92 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Claude finished @alukach's task in 19s —— View job ✅ No blocking issues — safe to merge.
|
|
🚀 Latest commit deployed to https://source-data-proxy-pr-166.source-coop.workers.dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the
multistoregit-branch pin inCargo.lockfrom71b1513a→71e51edd.mainbuilds against thefix/decode-aws-chunked-writesbranch of multistore via the temporary[patch.crates-io]block (added in #162). That branch got a follow-up fix from a 4-agent review, and this bumps the lock to pick it up.Why
The pinned commit (
71b1513a) had a bug: a default aws-cli/SDK aws-chunkedPutObjectto a non-S3 backend (azure — which is enabled here) reached the S3-only seed-signing path (build_streaming_forward) with no backend-type guard, so it mis-routed into S3 SigV4 signing instead of being rejected.UploadPartalready guarded this earlier;PutObjectdid not.71e51edd(multistore#92):is_s3_backend()and rejects non-S3 streaming uploads withInvalidRequest;Internalre-read ofx-amz-content-sha256;UploadParttest.Verification
Pre-commit hook built the wasm worker against
71e51eddand ran the full data.source.coop suite (green). multistore-side:clippy -D warningsclean, 111 tests, wasmcf-workerscompiles.Note
This is a lock bump against the temporary git-branch patch. Once multistore #92 ships in a release, the
[patch.crates-io]block should be dropped and themultistore*deps bumped to the released version (see the TODO inCargo.toml).🤖 Generated with Claude Code