fix: avoid overlapping definition for T::Enum synthetic serialize() method #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the synthetic
serialize()definition generation.Motivation
When users click "Find References" on a
T::Enumclass name in Sourcegraph, the UI sometimes shows references to theserialize()method instead of references to the class itself.This happens because
scip-rubyemits two definitions at the exact same source location:Foo#)serialize()method (e.g.,Foo#serialize().)When the Sourcegraph frontend queries for the symbol at a position and finds multiple overlapping definitions, it may pick the wrong one, causing Find References to return incorrect results.
Now only definition for the class is provided:
Problem
The synthetic serialize() method definition was emitted at the T::Enum class
declaration location, causing overlapping definitions with the class itself.
This broke Find References in Sourcegraph UI, which would pick up serialize
references instead of class references.
Before
After
Test plan
See included automated tests.