Extensively test base URLs with path at the indexer level#805
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: Expands CLI index coverage for configurations where the top-level Changes:
Technical Notes: The tests normalize thread annotations in stderr and assert on deterministic output (either expected stderr logs or sorted output directory manifests). 🤖 Was this summary useful? React with 👍 or 👎 |
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 2fa6e44 | Previous: e45ee90 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
19 ms |
19 ms |
1 |
Add one schema (100 existing) |
25 ms |
24 ms |
1.04 |
Add one schema (1000 existing) |
75 ms |
70 ms |
1.07 |
Add one schema (10000 existing) |
726 ms |
583 ms |
1.25 |
Update one schema (1 existing) |
19 ms |
20 ms |
0.95 |
Update one schema (101 existing) |
25 ms |
24 ms |
1.04 |
Update one schema (1001 existing) |
78 ms |
76 ms |
1.03 |
Update one schema (10001 existing) |
636 ms |
605 ms |
1.05 |
Cached rebuild (1 existing) |
10 ms |
10 ms |
1 |
Cached rebuild (101 existing) |
12 ms |
12 ms |
1 |
Cached rebuild (1001 existing) |
32 ms |
31 ms |
1.03 |
Cached rebuild (10001 existing) |
250 ms |
245 ms |
1.02 |
Index 100 schemas |
111 ms |
109 ms |
1.02 |
Index 1000 schemas |
1057 ms |
960 ms |
1.10 |
Index 10000 schemas |
13459 ms |
13200 ms |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 2fa6e44 | Previous: e45ee90 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
18 ms |
19 ms |
0.95 |
Add one schema (100 existing) |
23 ms |
23 ms |
1 |
Add one schema (1000 existing) |
77 ms |
75 ms |
1.03 |
Add one schema (10000 existing) |
659 ms |
627 ms |
1.05 |
Update one schema (1 existing) |
16 ms |
17 ms |
0.94 |
Update one schema (101 existing) |
23 ms |
24 ms |
0.96 |
Update one schema (1001 existing) |
79 ms |
75 ms |
1.05 |
Update one schema (10001 existing) |
676 ms |
646 ms |
1.05 |
Cached rebuild (1 existing) |
10 ms |
9 ms |
1.11 |
Cached rebuild (101 existing) |
11 ms |
11 ms |
1 |
Cached rebuild (1001 existing) |
33 ms |
31 ms |
1.06 |
Cached rebuild (10001 existing) |
271 ms |
251 ms |
1.08 |
Index 100 schemas |
126 ms |
145 ms |
0.87 |
Index 1000 schemas |
1038 ms |
1104 ms |
0.94 |
Index 10000 schemas |
13862 ms |
13780 ms |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
jviotti
commented
Apr 2, 2026
jviotti
commented
Apr 2, 2026
| Using configuration: $(realpath "$TMP")/one.json | ||
| Detecting: $(realpath "$TMP")/schemas/foo.json (#1) | ||
| EOF | ||
| diff "$TMP/output.txt" "$TMP/expected.txt" |
Member
Author
There was a problem hiding this comment.
Assert on the final find + sort output
jviotti
commented
Apr 2, 2026
jviotti
commented
Apr 2, 2026
| } | ||
|
|
||
| # Run 1: build with path URL | ||
| "$1" --skip-banner "$TMP/one.json" "$TMP/output" --concurrency 1 > /dev/null 2>&1 |
Member
Author
There was a problem hiding this comment.
Assert on the find + sort output at this point
jviotti
commented
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com