Skip to content

Extensively test base URLs with path at the indexer level#805

Merged
jviotti merged 4 commits intomainfrom
index-url-with-base
Apr 2, 2026
Merged

Extensively test base URLs with path at the indexer level#805
jviotti merged 4 commits intomainfrom
index-url-with-base

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented Apr 2, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 20 files

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Apr 2, 2026

🤖 Augment PR Summary

Summary: Expands CLI index coverage for configurations where the top-level url contains a path segment.

Changes:

  • Adds a comprehensive set of test/cli/index/common/url-with-path*.sh cases (plain, trailing slash, deep path, baseUri override, nested collections/pages, subdirectories, schema-extension handling, and YAML inputs).
  • Adds validation tests for error handling when a schema $id is outside the configured base and when a schema references an unregistered external URI.
  • Adds rebuild/cache regression tests to ensure changing the configured url between “no-path” and “path” triggers a full rebuild, while an unchanged config remains a cache hit.
  • Registers all new scenarios in test/cli/CMakeLists.txt under the ONE_INDEX test suite.

Technical Notes: The tests normalize thread annotations in stderr and assert on deterministic output (either expected stderr logs or sorted output directory manifests).

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 2fa6e44 Previous: e45ee90 Ratio
Add one schema (0 existing) 19 ms 19 ms 1
Add one schema (100 existing) 25 ms 24 ms 1.04
Add one schema (1000 existing) 75 ms 70 ms 1.07
Add one schema (10000 existing) 726 ms 583 ms 1.25
Update one schema (1 existing) 19 ms 20 ms 0.95
Update one schema (101 existing) 25 ms 24 ms 1.04
Update one schema (1001 existing) 78 ms 76 ms 1.03
Update one schema (10001 existing) 636 ms 605 ms 1.05
Cached rebuild (1 existing) 10 ms 10 ms 1
Cached rebuild (101 existing) 12 ms 12 ms 1
Cached rebuild (1001 existing) 32 ms 31 ms 1.03
Cached rebuild (10001 existing) 250 ms 245 ms 1.02
Index 100 schemas 111 ms 109 ms 1.02
Index 1000 schemas 1057 ms 960 ms 1.10
Index 10000 schemas 13459 ms 13200 ms 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 2fa6e44 Previous: e45ee90 Ratio
Add one schema (0 existing) 18 ms 19 ms 0.95
Add one schema (100 existing) 23 ms 23 ms 1
Add one schema (1000 existing) 77 ms 75 ms 1.03
Add one schema (10000 existing) 659 ms 627 ms 1.05
Update one schema (1 existing) 16 ms 17 ms 0.94
Update one schema (101 existing) 23 ms 24 ms 0.96
Update one schema (1001 existing) 79 ms 75 ms 1.05
Update one schema (10001 existing) 676 ms 646 ms 1.05
Cached rebuild (1 existing) 10 ms 9 ms 1.11
Cached rebuild (101 existing) 11 ms 11 ms 1
Cached rebuild (1001 existing) 33 ms 31 ms 1.06
Cached rebuild (10001 existing) 271 ms 251 ms 1.08
Index 100 schemas 126 ms 145 ms 0.87
Index 1000 schemas 1038 ms 1104 ms 0.94
Index 10000 schemas 13862 ms 13780 ms 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Using configuration: $(realpath "$TMP")/one.json
Detecting: $(realpath "$TMP")/schemas/foo.json (#1)
EOF
diff "$TMP/output.txt" "$TMP/expected.txt"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert on the final find + sort output

}

# Run 1: build with path URL
"$1" --skip-banner "$TMP/one.json" "$TMP/output" --concurrency 1 > /dev/null 2>&1
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert on the find + sort output at this point

jviotti added 2 commits April 2, 2026 12:19
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit 1d6a37b into main Apr 2, 2026
6 checks passed
@jviotti jviotti deleted the index-url-with-base branch April 2, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant