fix(cmd): reject an unrecognised --output value - #132
Merged
Conversation
The writer selection had a default arm, so any value that was not exactly "json" was silently accepted as pretty: `specs -o josn version` exited 0 with plausible output. A typo in a pipeline then failed several lines later at the jq, with a parse error rather than a message naming the flag. output.Format now names the accepted values, so the flag default, the writer selection and the help text read from one place instead of repeating a bare string literal. PersistentPreRunE rejects anything else. The writer is wired before the format is validated. That ordering reads backwards on purpose: main reports the returned error through app.Output, so a rejection raised while it is still nil would have nowhere to go. Closes #115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The writer selection had a default arm, so any value that was not exactly
"json" was silently accepted as pretty:
specs -o josn versionexited 0 withplausible output. A typo in a pipeline then failed several lines later at the
jq, with a parse error rather than a message naming the flag.
output.Format now names the accepted values, so the flag default, the writer
selection and the help text read from one place instead of repeating a bare
string literal. PersistentPreRunE rejects anything else.
The writer is wired before the format is validated. That ordering reads
backwards on purpose: main reports the returned error through app.Output, so a
rejection raised while it is still nil would have nowhere to go.
Closes #115
Stack created with GitHub Stacks CLI • Give Feedback 💬