test: load through helpers that cannot return nil

[Ilyes512]

Top of the stack on #140. Test-only — no production code changes.

The finding

LoadMetadata, LoadStatus and registry.Load all report an absent file as (nil, nil), so every caller has to check the pointer before reading it. Nine test sites wrote that check out by hand, and staticcheck flags each as SA5011: possible nil pointer dereference — it does not model t.Fatal as ending the test, so it sees a nil check followed by an unguarded read.

The check is correct. But writing it nine times is what put it in front of the linter nine times. Each package now gains one mustLoad… helper that fails the test when the value is absent and otherwise returns a pointer known to be non-nil — a contract a caller cannot get wrong, and one the analyser has no reason to question. It also drops 4 lines of boilerplate per site.

Why it did not show up in CI

Same golangci-lint (v2.12.2) and same config in both places; the difference is the Go toolchain. CI pins Go from go.mod via GOTOOLCHAIN: local (1.26.1) and reports 0 issues. The golangci/golangci-lint:v2.12.2-alpine image that task lint uses ships 1.26.2, where the same staticcheck build reaches a different conclusion on these nine sites.

So it is a false positive today, but a latent CI failure the moment go.mod is bumped to 1.26.2 — reason enough to resolve it rather than suppress it with //nolint or a config exclusion.

Scope note

task lint originally reported only 6 findings because golangci-lint caps duplicates (max-same-issues). Running with --max-same-issues=0 --max-issues-per-linter=0 showed 17 across 5 files, which is what this fixes; that same command now reports 0 issues.

Checks

task lint (and the uncapped variant), go test -race, go test -tags=integration -race ./internal/cmd/..., gofmt and go build all clean.

Because a helper that silently returned a zero value would make these tests pass vacuously, I mutation-checked it: breaking LoadMetadata's Updated-to-Created fallback makes TestLoadMetadata_MissingUpdated_FallsBackToCreated fail as it should.

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}