Ensure auth progress is stored on config changes#109
Merged
antonholmberg merged 1 commit intospotify:masterfrom Mar 4, 2026
Merged
Conversation
antonholmberg
force-pushed
the
fix-login-activity-not-canceling-when-recreated
branch
from
61522b4 to
b59af1d
Compare
pimpimmi
reviewed
Mar 4, 2026
| // - Handler reports auth in progress (user returned from browser without completing) | ||
| // We don't cancel when a handler exists but hasn't started auth yet | ||
| // (e.g. Custom Tabs service binding is still in progress). | ||
| if (authInProgress && |
Collaborator
There was a problem hiding this comment.
This if-statement it a bit hard to read. I'm wondering, since hasHandler and isHandlerAuthInProgress are only used here, perhaps consider merging them into hasHandlerWithoutAuthInProcess?
antonholmberg
force-pushed
the
fix-login-activity-not-canceling-when-recreated
branch
from
b59af1d to
bda83de
Compare
cedrich3
approved these changes
Mar 4, 2026
antonholmberg
deleted the
fix-login-activity-not-canceling-when-recreated
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change if you turned on "Do not keep activities" and pressed back from the consent screen, there would be a headless LoginActivity still running and you needed to press back again to get rid of it.