Support unordered Collection properties.#2324
Closed
lsh1215 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Sanghun Lee <vitash1215@gmail.com>
Contributor
|
Thanks. I moved the test so Single Query Loading gets tested as well. This is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change lets Spring Data JDBC represent unordered aggregate child collections that still allow duplicate elements by treating
Collectiondifferently from orderedListproperties.Root cause
BasicRelationalPersistentPropertypreviously classified every collection-like property exceptSetas list-like. As a result,Collection<Child>was treated as qualified and ordered, requiring an index/key column and using list-style generated-id aggregation.Changes
Listimplementations.CollectionAggregatorso generated child ids can be populated for unorderedCollectionproperties without a qualifier.Collectionbeing collection-like but not qualified or ordered.Collection<CollectionElement>without a key column.Verification
git diff --check upstream/main..HEAD./mvnw -pl spring-data-relational,spring-data-jdbc -Dtest=DefaultAggregatePathUnitTests,JdbcRepositoryWithListsIntegrationTests,JdbcRepositoryWithCollectionsIntegrationTests testCloses #848.