Decoupling Web Server APIs after Spring Boot modularization #3186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In the issue #3165 I found that the modularization introduced in Spring Boot 4 causes issues when deploying applications on external web server (with WAR files).
The
org.springframework.boot.web.serverpackage has now been moved to a separate module since the modularization of Spring Boot 4. It cannot and must not be included in a WAR deployment on an external application server (such as Tomcat, for example).The changes consist in removing any references to classes from
org.springframework.boot.web.serverinActuatorProvider, and providing them only in the context of an embedded application server.I used Suppliers for the data coming from a
WebServerInitializedEvent.I added tests to verify each step: