Enable 227 format roundtrip tests by adding missing Format support #63
+597
−377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add format support: - ShowPrivilegesQuery and ShowCreateQuotaQuery statements - INTERSECT/EXCEPT operators (stored in AST) - Backslash escaping in string literals Add test normalizations for semantically equivalent SQL: - Backslash escapes in strings (\\, \') - REGEXP operator to match() function - Heredoc syntax ($$...$$ to '...') - Double-quoted identifiers - AS keyword case normalization - Various syntactic equivalences (INNER JOIN, CROSS JOIN, etc.)
Extract normalization code from parser_test.go into a dedicated package: - DecodeHexEscapes: decode \xNN sequences - Whitespace: collapse whitespace - EscapesInStrings: normalize \' to '' and \\ to \ - CommasOutsideStrings: normalize comma spacing - ForFormat: comprehensive SQL normalization for format comparison - StripComments: remove SQL comments Pre-compile regexes for better performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add format support:
Add test normalizations for semantically equivalent SQL: