[81reap]

The rest of SQLPage used sqlx-oldapi's AnyPool, PoolConnection, rows and errors directly. The new driver module now owns those types:

Each enum has one variant for now. sqlx 0.9 can now be supported (issue #1056).

Behavior does not change.

Refs #1056

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[lovasoa]

I am not a huge fan of maintaining knowledge of both oldapi and newapi in the codebase at once. I welcome all the cleanups, cleaner module separations, etc we can do on main, and I'm ready to merge newapi all at once when it has been sufficiently exercised (maybe try it on some of the open source SQLPage apps out there first to increase confidence)

[lovasoa]

Another thing we can do on main is improving our end to end coverage in the automatically tested examples. Currently we don't have realistic end to end tests for duckdb or sqlserver, and I think adding at least one (medium complexity) example app for each, exercising each database's specificity, would greatly derisk the migration.

[datadog-official]

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f06e4d6 | Docs | Give us feedback!}

[81reap]

seems like this is the same thead as this convo so cross linking :: #1597 (comment)

Currently we don't have realistic end to end tests for duckdb or sqlserver, and I think adding at least one (medium complexity) example app for each, exercising each database's specificity, would greatly derisk the migration.

also 100% aligned. once we have a way to be able to run SQLPage against sqlx-oldapi and unstable-sqlx, we can start adding e2e tests to derisk and help build confidence in the Alpha -> Beta dialup

[lovasoa]

I'd like to first add the tests, then let them run naturally on ci in both branches.