-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feature: tool description for the Bash tool now advises model as to what the actual shell is (resolves #4866) #4917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ariane-emory
wants to merge
51
commits into
sst:dev
Choose a base branch
from
ariane-emory:feat/shell-advice
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+152
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Remove the fish/nu blacklist so commands execute in the user's actual shell. Previously, fish and nu were blacklisted and commands would fall back to zsh/bash, causing the tool description to incorrectly report the shell being used. Changes: - Remove fish/nu blacklist from bash.ts shell detection - Remove unused BLACKLIST constant and Shell.acceptable() from shell.ts - Add fish shell test case to bash.test.ts Resolves sst#4866
392aaa2 to
0ece1f7
Compare
…into feat/shell-advice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4866
This PR adjusts the tool description of the Bash tool dynamically so that it advises the model what shell the command it's going to run will actually be run in.
I've played with this for a couple of days, and it does seem to significantly reduce the likely hood of the what I'll call 'the usual shell rediscovery' loop which can happen if you're running opencode in a non-bash shell such as fish:
The usual shell rediscovery loop proceeds as follows:
Benefits