feat(tui): add inline Ctrl+R reverse-i-search for prompt history #6276
+201
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edlsh
force-pushed
the
feat/inline-ctrl-r-history-search
branch
2 times, most recently
from
fab03e0 to
fb1736c
Compare
Implements bash-style inline history search as suggested in sst#5062. Alternative approach to sst#5775's modal dialog. Features: - Inline reverse-i-search: preview matches directly in prompt textarea - Incremental substring search with real-time updates - Keyboard controls: Ctrl+R/Up cycle older, Down for newer, Enter accept, Esc/Ctrl+G cancel - Status line showing (reverse-i-search)'query': N/M - Full state preservation: prompt text, parts, extmarks, mode, cursor position - Configurable keybind (history_search, default: ctrl+r) Implementation details: - historySearch state tracks: active, query, matchIndex, originalPrompt, originalMode, originalCursorOffset - Exposed history.items getter for direct access to prompt history - History search takes precedence over shell-mode and other handlers when active - Paste blocked during search mode - Preview updates parts/extmarks consistently with normal history navigation Closes sst#5062 Related to sst#1701
edlsh
force-pushed
the
feat/inline-ctrl-r-history-search
branch
from
fb1736c to
35f4348
Compare
After accepting a history search match, set the history navigation index so Up/Down continues from that position instead of resetting. Adds setIndex method to PromptHistory context. Ref: sst#6276
Escape was being intercepted by session_interrupt (bound to escape) before reaching history search handler. Suspend command keybinds while history search is active so Escape/Ctrl+G properly cancel. Ref: sst#6276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements bash-style inline reverse-i-search for prompt history, as an alternative approach to #5775's modal dialog. This addresses #5062 and #1701.
As @ShpetimA suggested in #5062:
Demo
The search works inline in the prompt textarea with a status line in the footer:
Features
Ctrl+R/Up: Cycle to older matchesDown: Cycle to newer matchesEnter: Accept current matchEsc/Ctrl+G: Cancel and restore original prompthistory_search(default:ctrl+r)Implementation Details
historySearchstate to Prompt store tracking:active,query,matchIndex,originalPrompt,originalMode,originalCursorOffsethistory.itemsgetter for direct access to prompt historye.name === "space"handling)Why Inline vs Modal?
For a terminal TUI that already uses shell-like behaviors, inline Ctrl+R is the more cohesive choice.
Closes #5062
Related to #1701, #5775