chore: Bump helm chart versions ahead of 26.7#424
Conversation
The update script (.scripts/update_helm_charts.py) skipped these files
This was matching on vector-aggregator:
```yaml
version: "2"
```
This had a side-effect: When the `repo.url` is updated (eg: https://grafana.github.io/helm-charts -> https://grafana-community.github.io/helm-charts), but the user has a named repo with the old url (because the `repo.name` wasn't updated), this caused chart downgrades. Now we do an add and force update (once), along with a repo URL check and bail out with this message: ```⚠️ Error processing ./stacks/observability/grafana.yaml: You have a local repo named grafana pointing to https://grafana.github.io/helm-charts, but the stack/demo wants https://grafana-community.github.io/helm-charts Either delete or update your local repo URL, or update the stack/demo repo name so it doesn't conflict ```
Techassi
left a comment
There was a problem hiding this comment.
Looking good, just a few comments on the script.
| local_repo = next( | ||
| (repo for repo in local_repos if repo["name"] == repo_name), None | ||
| ) | ||
| if local_repo is not None: |
There was a problem hiding this comment.
I don't know Python well enough, but I think this can be done with the with keyword.
| if local_repo is not None: | |
| with local_repo: |
There was a problem hiding this comment.
Maybe, but I think these changes are good enough.
| name: vector | ||
| url: https://helm.vector.dev | ||
| version: 0.52.0 # app version 0.55.0 | ||
| version: 0.56.0 # appVersion: 0.56.0-distroless-libc |
There was a problem hiding this comment.
This has to be kept in sync with the rest of the platform, right? So 0.55.0 in this case.
There was a problem hiding this comment.
Ah yeah, good point.
Either we need a rule to skip vector (already done with usual bumps), or need to invent a special skip mechanism.
I'd rather do the former.
Co-authored-by: Techassi <git@techassi.dev>
These are currently tied to the vector version shipped with products via docker-images. Hopefully we can move to OTLP for the vector sidecar -> vector-aggregator.
| name: argo-cd | ||
| url: https://argoproj.github.io/argo-helm | ||
| version: 9.4.10 # v3.3.3 | ||
| version: 10.1.3 # appVersion: v3.4.5 |
There was a problem hiding this comment.
FYI, 3.4.5 just landed :D
They have new helm-chart repos.
dervoeti
left a comment
There was a problem hiding this comment.
fyi: signal-processing still uses https://grafana.github.io/helm-charts, not community.
Is that correct?
Fixed in dbaf0d9. |
Part of #422
Details