Skip to content

fix: Correct managed-by label value (.com → .tech) #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adwk67 merged 9 commits into from
Aug 20, 2026
Merged

fix: Correct managed-by label value (.com → .tech) #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
02a78b3
remove version from pvc listener labels, correct operator name
adwk67 Aug 13, 2026
de3a191
changelog
adwk67 Aug 13, 2026
6a5165d
add vendor label manually, adjust test assert
adwk67 Aug 13, 2026
838b8c7
Merge branch 'main' into fix/unversioned-restserver-labels
adwk67 Aug 13, 2026
c1b4366
added in wrongly removed labels
adwk67 Aug 13, 2026
83ca24e
added missing PR number to changelog
adwk67 Aug 14, 2026
2083d5c
merge main and fix conflicts
adwk67 Aug 20, 2026
88a956f
changelog update
adwk67 Aug 20, 2026
5f44e1b
fix test
adwk67 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,18 @@
- Fix a longstanding problem of including empty `categories`, `shortNames` and `additionalPrinterColumns` in the CRDs,
which could cause problems with GitOps tools (e.g. ArgoCD) reporting a diff in the custom resources.
See [our internal issue](https://github.com/stackabletech/hdfs-operator/issues/626) and [the fix](https://github.com/kube-rs/kube/pull/2042) for details ([#792]).
- BREAKING: The app.kubernetes.io/managed-by label value changed from hbase.stackable.com_hbasecluster to
hbase.stackable.tech_hbasecluster, aligning with all other operators ([#795]).
- BREAKING: The rest-server listener PVC template now carries the recommended labels without the
version label, so that the labels stay stable across upgrades.
Existing rest-server StatefulSets must be deleted once before the new operator can reconcile them ([#799]).

[#776]: https://github.com/stackabletech/hbase-operator/pull/776
[#782]: https://github.com/stackabletech/hbase-operator/pull/782
[#786]: https://github.com/stackabletech/hbase-operator/pull/786
[#787]: https://github.com/stackabletech/hbase-operator/pull/787
[#792]: https://github.com/stackabletech/hbase-operator/pull/792
[#795]: https://github.com/stackabletech/hbase-operator/pull/795
[#799]: https://github.com/stackabletech/hbase-operator/pull/799

## [26.7.0] - 2026-07-21
Expand Down
2 changes: 1 addition & 1 deletion rust/operator-binary/src/controller/build/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ mod tests {
("app.kubernetes.io/instance", "my-hbase".to_string()),
(
"app.kubernetes.io/managed-by",
"hbase.stackable.com_hbasecluster".to_string(),
"hbase.stackable.tech_hbasecluster".to_string(),
),
("app.kubernetes.io/name", "hbase".to_string()),
("app.kubernetes.io/version", app_version_label("2.6.3")),
Expand Down
2 changes: 1 addition & 1 deletion rust/operator-binary/src/crd/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ pub mod security;

pub const APP_NAME: &str = "hbase";
pub const FIELD_MANAGER: &str = "hbase-operator";
pub const HBASE_OPERATOR_NAME: &str = "hbase.stackable.com";
pub const HBASE_OPERATOR_NAME: &str = "hbase.stackable.tech";

// This constant is hard coded in hbase-entrypoint.sh
// You need to change it there too.
Expand Down
59 changes: 29 additions & 30 deletions tests/templates/kuttl/smoke/30-assert.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ metadata:
labels:
app.kubernetes.io/component: master
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand Down Expand Up @@ -46,7 +46,7 @@ metadata:
labels:
app.kubernetes.io/component: master
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
prometheus.io/scrape: "true"
Expand All @@ -73,7 +73,7 @@ metadata:
labels:
app.kubernetes.io/component: regionserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand Down Expand Up @@ -108,7 +108,7 @@ metadata:
labels:
app.kubernetes.io/component: regionserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
prometheus.io/scrape: "true"
Expand All @@ -135,7 +135,7 @@ metadata:
labels:
app.kubernetes.io/component: restserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand Down Expand Up @@ -170,7 +170,7 @@ metadata:
labels:
app.kubernetes.io/component: restserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
prometheus.io/scrape: "true"
Expand Down Expand Up @@ -199,7 +199,7 @@ metadata:
labels:
app.kubernetes.io/component: master
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
restarter.stackable.tech/enabled: "true"
Expand All @@ -224,7 +224,7 @@ spec:
labels:
app.kubernetes.io/component: master
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand Down Expand Up @@ -259,6 +259,8 @@ spec:
- pipefail
- -c
env:
- name: CONTAINERDEBUG_LOG_DIRECTORY
value: /stackable/log/containerdebug
- name: HADOOP_CONF_DIR
value: /stackable/conf
- name: HBASE_CONF_DIR
Expand All @@ -268,8 +270,6 @@ spec:
value: "false"
- name: STACKABLE_LOG_DIR
value: /stackable/log
- name: CONTAINERDEBUG_LOG_DIRECTORY
value: /stackable/log/containerdebug
imagePullPolicy: IfNotPresent
livenessProbe:
failureThreshold: 3
Expand Down Expand Up @@ -406,7 +406,7 @@ spec:
labels:
app.kubernetes.io/component: master
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand All @@ -430,7 +430,7 @@ metadata:
labels:
app.kubernetes.io/component: regionserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
restarter.stackable.tech/enabled: "true"
Expand All @@ -450,7 +450,7 @@ spec:
labels:
app.kubernetes.io/component: regionserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand Down Expand Up @@ -494,6 +494,8 @@ spec:
- pipefail
- -c
env:
- name: CONTAINERDEBUG_LOG_DIRECTORY
value: /stackable/log/containerdebug
- name: HADOOP_CONF_DIR
value: /stackable/conf
- name: HBASE_CONF_DIR
Expand All @@ -503,8 +505,6 @@ spec:
value: "false"
- name: STACKABLE_LOG_DIR
value: /stackable/log
- name: CONTAINERDEBUG_LOG_DIRECTORY
value: /stackable/log/containerdebug
imagePullPolicy: IfNotPresent
livenessProbe:
failureThreshold: 3
Expand Down Expand Up @@ -641,7 +641,7 @@ spec:
labels:
app.kubernetes.io/component: regionserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand All @@ -665,7 +665,7 @@ metadata:
labels:
app.kubernetes.io/component: restserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
restarter.stackable.tech/enabled: "true"
Expand All @@ -690,7 +690,7 @@ spec:
labels:
app.kubernetes.io/component: restserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand Down Expand Up @@ -725,6 +725,8 @@ spec:
- pipefail
- -c
env:
- name: CONTAINERDEBUG_LOG_DIRECTORY
value: /stackable/log/containerdebug
- name: HADOOP_CONF_DIR
value: /stackable/conf
- name: HBASE_CONF_DIR
Expand All @@ -734,8 +736,6 @@ spec:
value: "false"
- name: STACKABLE_LOG_DIR
value: /stackable/log
- name: CONTAINERDEBUG_LOG_DIRECTORY
value: /stackable/log/containerdebug
imagePullPolicy: IfNotPresent
livenessProbe:
failureThreshold: 3
Expand Down Expand Up @@ -871,7 +871,7 @@ spec:
labels:
app.kubernetes.io/component: restserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand All @@ -893,7 +893,7 @@ metadata:
labels:
app.kubernetes.io/component: regionserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
stackable.tech/vendor: Stackable
name: test-hbase
Expand All @@ -909,7 +909,7 @@ metadata:
labels:
app.kubernetes.io/component: master
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand All @@ -926,7 +926,7 @@ metadata:
labels:
app.kubernetes.io/component: regionserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand All @@ -943,7 +943,7 @@ metadata:
labels:
app.kubernetes.io/component: restserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand All @@ -959,7 +959,7 @@ kind: ServiceAccount
metadata:
labels:
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
name: test-hbase-serviceaccount
ownerReferences:
Expand All @@ -973,7 +973,7 @@ kind: RoleBinding
metadata:
labels:
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
name: test-hbase-rolebinding
ownerReferences:
Expand Down Expand Up @@ -1022,7 +1022,7 @@ metadata:
labels:
app.kubernetes.io/component: master
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand Down Expand Up @@ -1055,7 +1055,7 @@ metadata:
labels:
app.kubernetes.io/component: regionserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/managed-by: hbase.stackable.tech_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand Down Expand Up @@ -1088,7 +1088,6 @@ metadata:
labels:
app.kubernetes.io/component: restserver
app.kubernetes.io/instance: test-hbase
app.kubernetes.io/managed-by: hbase.stackable.com_hbasecluster
app.kubernetes.io/name: hbase
app.kubernetes.io/role-group: default
stackable.tech/vendor: Stackable
Expand Down
Loading