refactor: Introduce build aggregator#801
Conversation
adwk67
left a comment
There was a problem hiding this comment.
Looks fine, but we should look at the labelling mechanism.
| for (role, role_group_configs) in &cluster.role_groups { | ||
| for (role_group_name, rg_config) in role_group_configs { | ||
| services.push( | ||
| resource::service::rolegroup_headless_service(cluster, role, role_group_name) |
There was a problem hiding this comment.
This service construction looks different to what we do in e.g. HBase and Druid, where we use full v2 labelling mechanisms. Did we forget to do this for HDFS? HDFs stills constructs labels using plain strings, which the "new" mechanism doesn't allow (and which is why the resulting service builders are infallible, whereas HDFS's is fallible). Or was there a specific reason for this?
adwk67
left a comment
There was a problem hiding this comment.
How does this fit into the dereference/validate/build/apply paradigm?
let discovery_cm = build_discovery_config_map
That requires a client and can only be done once the listeners are deployed. I guess no way around that?
The |
Description
Part of stackabletech/issues#864.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker