Hardcode the use of the "default" profile for rustup#525
Conversation
At some point rustup changed the default profile from "default" to "minimal" if no other profile was specified. This caused our pre-commit checks to fail which rely on clippy which is not in the "minimal" profile. We now specify our dependency on the "default" profile explicitly to be more independent of future rustup changes.
|
I created an example PR here: stackabletech/hive-operator#606 Cargo will automatically install missing components/profiles if they are not already installed but specified in the |
nightkr
left a comment
nightkr
left a comment
There was a problem hiding this comment.
Alternatively, we might want to list out the specific components we care about. But this is fine for now.
|
FWIW, this will end up in the same templating batch as #524, so we'll likely need to manually |
|
Yeah, my initial attempt was to list all components but the docs say they can change between versions of rust. This will also include the OpenSearch operator inclusion which might also cause this to fail because that repo is private at the moment. If it does we'll have to remove it again for now. |
lfrancke
moved this from Development: Waiting for Review
to Development: Done
in Stackable Engineering
2 participants
At some point rustup changed the default profile from "default" to "minimal" if no other profile was specified.
This caused our pre-commit checks to fail which rely on clippy which is not in the "minimal" profile.
We now specify our dependency on the "default" profile explicitly to be more independent of future rustup changes.