Open
Conversation
maltesander
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
maltesander
requested changes
Feb 20, 2026
Comment on lines
+321
to
+322
| // IMPORTANT: We assume the CA certs are in PEM format because we know that `s3::v1alpha1::ConnectionSpec::volumes_and_mounts()` | ||
| // does NOT set the format annotation on the secret volumes. |
| name: minio-tls-ca | ||
| labels: | ||
| secrets.stackable.tech/class: minio-tls-ca | ||
| data: |
Member
There was a problem hiding this comment.
Can you document when and for how many days this was generated? And the subject name?
Member
Author
There was a problem hiding this comment.
it's a couple of lines above. the script used to generate these has all infos. is this not enough?
Member
There was a problem hiding this comment.
Without checking commits i dont see when it was generated? And later commits might change the subject etc. I think it makes sense commenting e.g.:
Created on 2026-02-20; Valid 36500 days; Subj: "/C=DE/ST=Schleswig-Holstein/L=Wedel/O=Stackable Signing Authority Inc/CN=stackable.de"
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes stackabletech/issues#809
✔️ Depends on the decision: https://github.com/stackabletech/decisions/issues/77
🟢 : CI https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/61/
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker