fix(docs): correct playbook commands and minor inconsistencies in Ubuntu Noble upgrade guide

[jasonrayne]

• Add missing -e flags to pulp-repo-publish.yml and pulp-repo-promote-production.yml playbook commands (without these flags, Noble repos are not promoted, causing apt failures on upgraded systems)
• Fix incorrect ceph-enter-maintenance.yml usage where ceph-exit-maintenance.yml should be used when taking hosts out of maintenance mode
• Fix typo: "change" -> "chance" in storage section potential issues

[gemini-code-assist]

Code Review

This pull request provides important corrections to the Ubuntu Noble upgrade documentation. The changes correctly add missing flags to playbook commands, fix incorrect playbook usage for Ceph maintenance operations, and correct a typo. These fixes significantly improve the accuracy and reliability of the upgrade guide. I've added a couple of suggestions to improve the readability of the long shell commands by splitting them across multiple lines.

[Alex-Welsh]

lgtm but unfortunately our CI won't run correctly on repo forks. I'd be in favor of force-merging this though as it's such a simple docs change.

@mnasiadka or @priteau are required for that

[priteau]

@jasonrayne Thank you for these fixes! I am just confused by why you need to set stackhpc_pulp_sync_ubuntu_noble at all, since it should be true:

stackhpc_pulp_sync_ubuntu_noble: "{{ os_distribution == 'ubuntu' }}"

Can you double check your configuration settings?

[priteau]

And on 2024.1 the variable is set as: stackhpc_pulp_sync_ubuntu_noble: "{{ os_release == 'noble' }}"

[jackhodgkiss]

@priteau I think the problem is if you are on Ubuntu Jammy and 2024.1 you it won't sync Noble packages as observed during the upgrade process.

https://github.com/stackhpc/stackhpc-kayobe-config/blob/stackhpc/2024.1/etc/kayobe/pulp.yml#L70

[jasonrayne]

@priteau Jack is correct. My KC is synced with SKC stackhpc/2024.1, and I was not planning to fully switch to 2025.1 until after the Noble upgrades were complete. So my pulp.yml still has stackhpc_pulp_sync_ubuntu_noble: "{{ os_release == 'noble' }}" rather than stackhpc_pulp_sync_ubuntu_noble: "{{ os_distribution == 'ubuntu' }}".

[seunghun1ee]

@jasonrayne So, is it meant to be a fix for stackhpc/2024.1 branch?
The ceph playbook & typo fixes make sense for both stackhpc/2025.1 and stackhpc/2024.1 but pulp playbook fix doesn't.

[jasonrayne]

@seunghun1ee Seems like it might help avoid some confusion for users if we just apply this to both branches, honestly.

Jack and I both defaulted to following the 2025.1 docs for the upgrade process, which would have been fine except for the fact that the Noble upgrade is ideally done before switching one's KC from 2024.1 to 2025.1, which creates a bit of an awkward crossover.

[jovial]

Thanks - I've included these in #2139 as our CI doesn't run against external PRs currently :(