Add ARM64 overcloud host image builds#1941
Open
cityofships wants to merge 6 commits intostackhpc/2025.1from
Open
Add ARM64 overcloud host image builds#1941cityofships wants to merge 6 commits intostackhpc/2025.1from
cityofships wants to merge 6 commits intostackhpc/2025.1from
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Member
Author
Alex-Welsh
requested changes
Oct 21, 2025
Member
Alex-Welsh
left a comment
There was a problem hiding this comment.
It would be nice to include some validation to make sure we're actually building images for the right arch.
Unfortunately it doesn't come out of qemu-img info, the cleanest I have of finding it is:
sudo apt install -y libguestfs-tools
sudo guestfish --ro -a path/to/image -i file /bin/bash | grep x86-64
or
sudo apt install -y libguestfs-tools
sudo guestfish --ro -a path/to/image -i file /bin/bash | grep aarch64
Co-authored-by: Alex Welsh <alex@stackhpc.com>
Member
|
@cityofships looks like you have a conflict. Needs a rebase, and probably worth squashing while you're at it |
Member
|
Can you prevent upload of ARM64 images to Leafcloud? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to #1497.
Depends on: stackhpc/stackhpc-release-train#441