Conversation
etc/kayobe/environments/stackhpc-baremetal/ansible/baremetal-0-enroll-overcloud.yml
Outdated
Show resolved
Hide resolved
etc/kayobe/environments/stackhpc-baremetal/ansible/baremetal-0-enroll-overcloud.yml
Outdated
Show resolved
Hide resolved
etc/kayobe/environments/stackhpc-baremetal/ansible/baremetal-1-check-bmc-up.yml
Outdated
Show resolved
Hide resolved
etc/kayobe/environments/stackhpc-baremetal/ansible/recover-baremetal.yml
Show resolved
Hide resolved
|
|
||
| - name: Undeploy baremetals in 'deploy failed' or 'error' state | ||
| ansible.builtin.command: | ||
| cmd: "{{ venv }}/bin/openstack baremetal node undeploy {{ inventory_hostname }}" |
There was a problem hiding this comment.
JohnG "Maybe lets move this into ./baremetal-4-clean.yml, at least for deploy failed."
etc/kayobe/environments/stackhpc-baremetal/inventory/group_vars/baremetal-redfish/ironic
Outdated
Show resolved
Hide resolved
etc/kayobe/environments/stackhpc-sushy-baremetal/ansible/auto-setup.yml
Outdated
Show resolved
Hide resolved
etc/kayobe/environments/stackhpc-sushy-baremetal/ansible/create-virtual-baremetal.yml
Outdated
Show resolved
Hide resolved
etc/kayobe/environments/stackhpc-sushy-baremetal/ansible/sushy-emulator.yml
Outdated
Show resolved
Hide resolved
etc/kayobe/environments/stackhpc-sushy-baremetal/ansible/vbmc-net.xml.j2
Outdated
Show resolved
Hide resolved
etc/kayobe/environments/stackhpc-sushy-baremetal/ansible/vbmc-pool.xml.j2
Show resolved
Hide resolved
| @@ -0,0 +1,3 @@ | |||
| --- | |||
|
|
|||
| stackhpc_lvm_lv_var_size: 10g | |||
There was a problem hiding this comment.
JohnG "lets add a comment around why we need this here."
There was a problem hiding this comment.
I'd be tempted to ditch this as it isn't ironic specific. You could have an environment specific hook that asserts this LV is big enough?
+1 for the comment if this is actually needed
There was a problem hiding this comment.
This is only for the aio test env at least.
It might be because IPA gets downloaded into var, or something odd like that, I forget what it was now?
etc/kayobe/environments/stackhpc-sushy-baremetal/inventory/group_vars/sushy-libvirt/ironic
Outdated
Show resolved
Hide resolved
etc/kayobe/environments/stackhpc-baremetal/ansible/baremetal-0-enroll-baremetal.yml
Outdated
Show resolved
Hide resolved
etc/kayobe/environments/stackhpc-baremetal/ansible/baremetal-0-enroll-baremetal.yml
Outdated
Show resolved
Hide resolved
dougszumski
left a comment
There was a problem hiding this comment.
I think it would help to split this into smaller PRs, like perhaps:
- General support for configuring Ironic and enrolling baremetal nodes
- Support for deploying baremetal nodes for the control plane
- Sushy support for CI testing
What do you think?
etc/kayobe/environments/stackhpc-sushy-baremetal/inventory/group_vars/sushy-libvirt/ironic
Outdated
Show resolved
Hide resolved
| Description=Virtual Redfish BMC service | ||
|
|
||
| [Service] | ||
| ExecStart=/opt/kayobe/venvs/sushy/bin/sushy-emulator -i 192.168.33.3 -p 34343 --config /etc/sushy/sushy.conf --debug |
There was a problem hiding this comment.
nit: You could reference ironic_redfish_address here
You might want to split it up to make it easier. eg.
ironic_redfish_ip: 192.168.33.3
ironic_redfish_port: 34343
ironic_redfish_address: "{{ ironic_redfish_ip }}:{{ ironic_redfish_port}}"
etc/kayobe/environments/stackhpc-sushy-baremetal/ansible/sushy-2.yml
Outdated
Show resolved
Hide resolved
| KAYOBE_CONFIG_PATH: "{{ lookup('env', 'KAYOBE_CONFIG_PATH') }}" | ||
|
|
||
| tasks: | ||
| - name: Run Sushy 1 playbook |
There was a problem hiding this comment.
nit: It would be helpful to give it a more descriptive name to the playbook / task description
There was a problem hiding this comment.
I've changed the format of this auto-setup playbook let me know what you think
| ram: "{{ 42 * 1024 }}" | ||
| vcpus: 42 | ||
| disk: 10 | ||
| ephemeral: 10 |
There was a problem hiding this comment.
We should be able to delete this? It's not relevant for BM
| disk: 10 | ||
| ephemeral: 10 | ||
| extra_specs: "{{ { | ||
| ('resources:CUSTOM_' ~ ironic_resource_class | upper ): 1, |
There was a problem hiding this comment.
We don't want user created BM instances to get scheduled to control plane hardware, so should we make this custom resource class specific to the control plane?
call it ironic_control_plane_resource_class or something?
| # todo: Support mutiple resource classes | ||
| run_once: true | ||
|
|
||
| - name: Create key pair for baremetal |
There was a problem hiding this comment.
Create key pair for baremetal control plane instances?
| ----------------------- | ||
|
|
||
| This environment is intended to be layered on top of a base Kayobe environment | ||
| (e.g. ``ci-aio``), so that baremetal-specific defaults override those provided |
There was a problem hiding this comment.
I guess most people will be trying to layer it on to the default kayobe config for non-CI environments? Like production sites etc? It might be helpful to make the primary use case here?
| Baremetal Environment | ||
| ===================== | ||
|
|
||
| This environment provides playbooks to automate the enrollment, inspection |
There was a problem hiding this comment.
It seems to do a lot more than this - like deploying the control plane HW. I am wondering if that part should be split out into another env?
…fish address var in group_vars/sushy-libvirt/ironic
No description provided.