Skip to content

Skc baremetal environment#2023

Open
claudia-lola wants to merge 8 commits intostackhpc/2025.1from
skc-baremetal-environment
Open

Skc baremetal environment#2023
claudia-lola wants to merge 8 commits intostackhpc/2025.1from
skc-baremetal-environment

Conversation

@claudia-lola
Copy link
Contributor

No description provided.


- name: Undeploy baremetals in 'deploy failed' or 'error' state
ansible.builtin.command:
cmd: "{{ venv }}/bin/openstack baremetal node undeploy {{ inventory_hostname }}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JohnG "Maybe lets move this into ./baremetal-4-clean.yml, at least for deploy failed."

@@ -0,0 +1,3 @@
---

stackhpc_lvm_lv_var_size: 10g
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JohnG "lets add a comment around why we need this here."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be tempted to ditch this as it isn't ironic specific. You could have an environment specific hook that asserts this LV is big enough?

+1 for the comment if this is actually needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for the aio test env at least.

It might be because IPA gets downloaded into var, or something odd like that, I forget what it was now?

Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would help to split this into smaller PRs, like perhaps:

  1. General support for configuring Ironic and enrolling baremetal nodes
  2. Support for deploying baremetal nodes for the control plane
  3. Sushy support for CI testing

What do you think?

Description=Virtual Redfish BMC service

[Service]
ExecStart=/opt/kayobe/venvs/sushy/bin/sushy-emulator -i 192.168.33.3 -p 34343 --config /etc/sushy/sushy.conf --debug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You could reference ironic_redfish_address here

You might want to split it up to make it easier. eg.

ironic_redfish_ip: 192.168.33.3
ironic_redfish_port: 34343

ironic_redfish_address: "{{ ironic_redfish_ip }}:{{ ironic_redfish_port}}"

KAYOBE_CONFIG_PATH: "{{ lookup('env', 'KAYOBE_CONFIG_PATH') }}"

tasks:
- name: Run Sushy 1 playbook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It would be helpful to give it a more descriptive name to the playbook / task description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the format of this auto-setup playbook let me know what you think

ram: "{{ 42 * 1024 }}"
vcpus: 42
disk: 10
ephemeral: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to delete this? It's not relevant for BM

disk: 10
ephemeral: 10
extra_specs: "{{ {
('resources:CUSTOM_' ~ ironic_resource_class | upper ): 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want user created BM instances to get scheduled to control plane hardware, so should we make this custom resource class specific to the control plane?
call it ironic_control_plane_resource_class or something?

# todo: Support mutiple resource classes
run_once: true

- name: Create key pair for baremetal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create key pair for baremetal control plane instances?

-----------------------

This environment is intended to be layered on top of a base Kayobe environment
(e.g. ``ci-aio``), so that baremetal-specific defaults override those provided
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess most people will be trying to layer it on to the default kayobe config for non-CI environments? Like production sites etc? It might be helpful to make the primary use case here?

Baremetal Environment
=====================

This environment provides playbooks to automate the enrollment, inspection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to do a lot more than this - like deploying the control plane HW. I am wondering if that part should be split out into another env?

…fish address var in group_vars/sushy-libvirt/ironic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants