Rotate credentials for ci-builder env#2135
Draft
Alex-Welsh wants to merge 1 commit intostackhpc/2025.1from
Draft
Rotate credentials for ci-builder env#2135Alex-Welsh wants to merge 1 commit intostackhpc/2025.1from
Alex-Welsh wants to merge 1 commit intostackhpc/2025.1from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully rotates credentials for the ci-builder environment. It introduces a new dedicated read-only user, skc-ci-builder-reader, for pulling package repositories from Ark, replacing the previous skc-ci-aio user. Additionally, the associated vault passwords for both stackhpc_repo_mirror_password and stackhpc_docker_registry_password have been updated. These changes align with the stated objective of enhancing security by using unique and appropriately scoped credentials.
Member
Author
|
Converting to draft so no one merges this until next week. I don't want to deal with any fallout over the weekend and I'll be off on Monday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a new user (read only) for pulling package repos from Ark, instead of using the AIO user again
Also changed the vault PW be unique (added to password manager)
Same rules apply as normal, will need to update the secret in GitHub and backport once merged