Skip to content

Dependencies updated or ignored for CVE vulnerabilities#2173

Open
elelaysh wants to merge 1 commit intostackhpc/2025.1from
ft/bump-grafana-etcd
Open

Dependencies updated or ignored for CVE vulnerabilities#2173
elelaysh wants to merge 1 commit intostackhpc/2025.1from
ft/bump-grafana-etcd

Conversation

@elelaysh
Copy link
Contributor

  • bump cadvisor to 0.56.2

  • Ignore CVE-2024-24790 in prometheus mtail exporter
    control plane is trusted

  • Upgrade prometheus-msteams to 1.5.3 to fix CVE-2023-24538 CVE-2023-24540

  • Bump grafana to 12.3.3 to fix CVE-2025-68121
    grafana server 12.3.3 is fixed but the opensearch-datasource plugin is still affected.

  • Bump etcd to 3.5.27 to fix CVE-2025-68121

  • Ignore CVE-2025-68121 for prometheus images

    • server-side: exporters and server are not listening with tls
    • as client: only querying known services
  • Ignore CVE-2025-68121 for influxdb
    No new version is available and it runs on a secure network

  • Ignore CVE-2025-68121 for letsencrypt-lego
    it only talks to known servers

  • Ignore CVE-2025-68121 for neutron
    report caused by docker client and we don't speak to remote docker over tls

@elelaysh elelaysh requested a review from a team as a code owner February 24, 2026 13:20
- bump cadvisor to 0.56.2

- Ignore CVE-2024-24790 in prometheus mtail exporter
  control plane is trusted

- Upgrade prometheus-msteams to 1.5.3
  to fix CVE-2023-24538 CVE-2023-24540

- Bump grafana to 12.3.3 to fix CVE-2025-68121
  grafana server 12.3.3 is fixed but the opensearch-datasource plugin
  is still affected.

- Bump etcd to 3.5.27 to fix CVE-2025-68121

- Ignore CVE-2025-68121 for prometheus images
  - server-side: exporters and server are not listening with tls
  - as client: only querying known services

- Ignore CVE-2025-68121 for influxdb
  No new version is available and it runs on a secure network

- Ignore CVE-2025-68121 for letsencrypt-lego
  it only talks to known servers

- Ignore CVE-2025-68121 for neutron
  it is the docker client that triggers it and we don't speak to remote
  docker over tls
@elelaysh elelaysh force-pushed the ft/bump-grafana-etcd branch from d90bbda to c50bc98 Compare February 24, 2026 13:22
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies to address CVEs and ignores others with justifications. The dependency updates for etcd, cadvisor, and prometheus-msteams look correct. The CVE suppressions are also in line with the descriptions. My main feedback is to add the justifications for ignoring CVEs as comments in the allowed-vulnerabilities.yml file. This will improve the maintainability of the configuration by making it self-documenting, explaining why certain vulnerabilities are considered acceptable risks in this context.

@elelaysh
Copy link
Contributor Author

Cherry-picked 3c961f2 from stackhpc/2024.1

@Alex-Welsh
Copy link
Member

@elelaysh are you going to rebuild against this spec, or do the current containers conform to this?

Comment on lines +38 to +40
[prometheus-msteams]
version = 1.5.3
sha256 = amd64:8eae63d89338f53a990fa2720b3fabf58c916e2648c948ce1e0f29942459a491
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be required because prometheus-msteams was removed from Kolla in 2025.1: https://review.opendev.org/c/openstack/kolla/+/927000

Comment on lines +86 to +88
prometheus_msteams_allowed_vulnerabilities:
- CVE-2024-45337
- CVE-2025-68121
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants