Fix Rocky minor version strict typing#2174
Merged
Alex-Welsh merged 1 commit intostackhpc/2025.1from Feb 25, 2026
Merged
Conversation
elelaysh
approved these changes
Feb 24, 2026
Contributor
elelaysh
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where an integer-typed Rocky minor version caused a lookup failure in dictionaries with string keys. The changes correctly apply the | string filter to the version variable before using it as a dictionary key. My review includes a suggestion to improve the robustness of one of the lookups by using the .get() method to provide a default value, which corrects a subtle issue with the current use of the default filter.
priteau
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran the
pulp-repo-sync.ymland got a very long error trace that ended like this:After a bit of fishing, I found that the issue was I had set:
stackhpc_pulp_repo_rocky_9_minor_version: 7and not
stackhpc_pulp_repo_rocky_9_minor_version: '7'i.e. the minor version was an integer, not a string.
That meant this this lookup failed:
Fixed by a string filter on the lookup. Same fix applied to other instances where the minor version is used