Use Docker 29 on 2024.1 Caracal#2175
Conversation
Docker can be updated to version 29 using a package update. We risk downgrading to 28 when running `kayobe overcloud host configure`, which might be worse than the upgrade from 28 to 29. Revert "limit docker-ce to 28 on Caracal" This reverts commit 18027ca. Revert "Fix Docker version check" This reverts commit 01de41a.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the configuration to allow using Docker version 29 on Caracal. The changes involve removing the explicit version pinning for Docker packages, which previously limited it to version 28, and updating the test configuration to accept Docker versions up to 30.0 (exclusive). The changes are consistent with the goal of the pull request and appear correct. I have no further suggestions.
elelaysh
left a comment
elelaysh
left a comment
There was a problem hiding this comment.
OK, it's simpler than using versionlock to keep docker 28, that we would need to lift at a later upgrade
|
Why did we limit it in the first place? I was probably told before but have forgotten |
We have been seeing issues where OVS containers failed to fully delete: the container is gone from the docker ps -a output but still running in the background. This leads to PID conflicts with the new containers launched by kolla-ansible. |
And we're confident the error is gone? |
Not 100% sure but I haven't seen issues when updating to Docker 29 in another deployment. |
3 participants
Docker can be updated to version 29 using a package update. We risk downgrading to 28 when running
kayobe overcloud host configure, which might be worse than the upgrade from 28 to 29.Revert "limit docker-ce to 28 on Caracal"
This reverts commit 18027ca.
Revert "Fix Docker version check"
This reverts commit 01de41a.