Skip to content

Add Rocky 10 repositories#2177

Open
owenjones wants to merge 5 commits intostackhpc/2025.1from
rl10-repos
Open

Add Rocky 10 repositories#2177
owenjones wants to merge 5 commits intostackhpc/2025.1from
rl10-repos

Conversation

@owenjones
Copy link

  • some of the RL9 repositories might also be required in RL10 (is there a list of what we want in each image somewhere?), so will possibly need to come back and fix the required flag on those to include them
  • it feels like there's scope for templating this a bit better as there's a lot of duplication between RL9 and RL10 entries, but that will need a bit of planning

@owenjones owenjones requested a review from a team as a code owner February 26, 2026 09:29
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Rocky 10 repositories by defining new variables and configurations across several YAML files. The changes are extensive and largely mirror the existing setup for Rocky 9. While the approach is sound, I've identified a few critical copy-paste errors in repository URLs that would likely cause failures. I've also included a suggestion for improving naming consistency. Your observation in the PR description about the potential for templating to reduce duplication is a good one and should be considered for future refactoring.

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start.
When I added the repos to release train, I included repos for both Epoxy and Gazpacho, which seems to have caused some confusion. I apologise, I should've split those changes out into two PRs.

stackhpc_pulp_repo_centos_stream_10_nfv_openvswitch_version: 20260220T152827
stackhpc_pulp_repo_centos_stream_10_storage_ceph_squid_aarch64_version: 20260220T152827
stackhpc_pulp_repo_centos_stream_10_storage_ceph_squid_version: 20260220T152827
stackhpc_pulp_repo_centos_stream_10_storage_ceph_tentacle_aarch64_version: 20260220T152827
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think tentacle is required for this release. We definitely need Squid, and I'm now wondering if we need Reef...

I'll check that and get back to you

@Alex-Welsh
Copy link
Member

  • some of the RL9 repositories might also be required in RL10 (is there a list of what we want in each image somewhere?), so will possibly need to come back and fix the required flag on those to include them

I think you need a combination of this file and the *.repo files in this directory. Looking at it now, I think I missed kolla_el10 in release train. I'll recheck that soon.

  • it feels like there's scope for templating this a bit better as there's a lot of duplication between RL9 and RL10 entries, but that will need a bit of planning

There certainly is. My concern would be there's enough that doesn't overlap that de-duplication of some parts and not others would just add complexity overall. In this case, let's keep going as we have before, but we should think about this for the next release. It would require a bit of planning as you say, and we're a bit late for that this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants