[DNM] Test docker-containerd-storage branch#2181
Draft
priteau wants to merge 1 commit intostackhpc/2025.1from
Draft
[DNM] Test docker-containerd-storage branch#2181priteau wants to merge 1 commit intostackhpc/2025.1from
priteau wants to merge 1 commit intostackhpc/2025.1from
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the kayobe dependency to point to the docker-containerd-storage branch. While this is likely for testing purposes as indicated by the '[DNM]' in the title, my feedback focuses on improving build reproducibility. I've suggested pinning the dependency to a specific commit hash instead of a branch name to prevent potential issues with non-reproducible builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.