fix: sort redfish_exporter_targets to avoid config changes#2184
Merged
priteau merged 1 commit intostackhpc/2024.1from Feb 27, 2026
Merged
fix: sort redfish_exporter_targets to avoid config changes#2184priteau merged 1 commit intostackhpc/2024.1from
redfish_exporter_targets to avoid config changes#2184priteau merged 1 commit intostackhpc/2024.1from
Conversation
When templating `redfish_exporter_targets` in `60-redfish.yml` the groups are written randomly and as a result can cause unnecessary updates to the templated file which can lead to reboots of prometheus as well as polluting configuration diff. Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an idempotency issue in the 60-redfish.yml Prometheus configuration by sorting the redfish_exporter_targets group. This ensures a consistent order for the generated scrape targets, preventing unnecessary configuration updates and potential service restarts. The implementation is correct and follows best practices for idempotent configurations. It would be beneficial to audit other configuration templates for similar unsorted loops over Ansible groups to further enhance system stability.
jackhodgkiss
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
jackhodgkiss
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
jackhodgkiss
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
jackhodgkiss
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
jackhodgkiss
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
jackhodgkiss
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
priteau
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When templating
redfish_exporter_targetsin60-redfish.ymlthe groups are written randomly and as a result can cause unnecessary updates to the templated file which can lead to reboots of prometheus as well as polluting configuration diff.