INFRA-908 Change grafana plugin install logic#991
Merged
priteau merged 1 commit intostackhpc/2025.1from Feb 27, 2026
Merged
Conversation
Member
|
@technowhizz , please could you placate the naysayers on the upstream PR? It would be good to finish this. |
Member
|
@technowhizz the upstream PR has been merged. Is this one ready to be merged? |
technowhizz
changed the title
Contributor
Author
|
@Alex-Welsh Once this PR is merged stackhpc/kolla#368 we can go ahead and merge this |
technowhizz
force-pushed
the
grafana-plugin-logic
branch
from
19df53d to
8c2ac59
Compare
technowhizz
force-pushed
the
grafana-plugin-logic
branch
2 times, most recently
from
4b976eb to
712e0b0
Compare
dougszumski
previously approved these changes
Jan 10, 2025
Member
dougszumski
left a comment
dougszumski
left a comment
There was a problem hiding this comment.
Default should come from Kolla after backport merges
technowhizz
force-pushed
the
grafana-plugin-logic
branch
from
712e0b0 to
85d250f
Compare
technowhizz
force-pushed
the
grafana-plugin-logic
branch
from
92e4c32 to
a6cd02f
Compare
Member
stackhpc/kolla#368 has merged, anything you want to add to this PR? |
technowhizz
force-pushed
the
grafana-plugin-logic
branch
from
354ce09 to
18510a8
Compare
technowhizz
force-pushed
the
grafana-plugin-logic
branch
from
18510a8 to
4b4bf1e
Compare
technowhizz
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
technowhizz
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
technowhizz
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
technowhizz
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
technowhizz
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
technowhizz
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
technowhizz
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
technowhizz
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
Alex-Welsh
force-pushed
the
grafana-plugin-logic
branch
from
40ced75 to
7ca3e8e
Compare
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Member
|
@technowhizz Except for the merge conflict which might need another image build, is this ready to merge? |
technowhizz
force-pushed
the
grafana-plugin-logic
branch
from
7ca3e8e to
a3a94dc
Compare
Contributor
Author
|
@priteau Ready to merge |
Member
|
@technowhizz Please rebase on top of stackhpc/2025.1 and run another container image build. |
priteau
approved these changes
Feb 23, 2026
priteau
previously approved these changes
Feb 27, 2026
Changing the way in which we specify grafana plugins to install. This is due to a change upstream which now allows plugins to be installed in an additive method instead of replacing the upstream default plugins [1]. [1] https://review.opendev.org/c/openstack/kolla/+/913184 Co-authored-by: Will Szumski <[email protected]>
priteau
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the changes needed to make use of https://review.opendev.org/c/openstack/kolla/+/913184 (if and when it gets merged).
This PR should only be merged if the above patch is in our kolla.