[release-v1.34] Fix unit tests aborting on bash 3.2 - #1522
Merged
ske-prow[bot] merged 1 commit intoAug 21, 2026
Merged
Conversation
Script hack/test.sh sets nounset and expands test_flags at line 27.
Outside CI that array is empty, and bash 3.2 treats the expansion of an
empty array as an unbound variable, so make verify aborts before it runs
a test. macOS ships bash 3.2.57 as /bin/bash.
Guard the expansion so it disappears when the array is empty. This
matches the ${timeout_flag:+...} guard in the same line.
stackit-ske
added
the
kind/cherry-pick
ske-prow
Bot
added
the
size/XS
dergeberl
approved these changes
Aug 21, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dergeberl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
Bot
added
lgtm
|
LGTM label has been added. DetailsGit tree hash: ca6d56ce36cc1168f7a7496b6ba355d86c799823 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1505
/assign dergeberl