Repository navigation
Conversation
rubenhoenle
reviewed
Nov 9, 2026
rubenhoenle
reviewed
Nov 9, 2026
rubenhoenle
reviewed
Nov 9, 2026
rubenhoenle
reviewed
Nov 9, 2026
rubenhoenle
reviewed
Nov 9, 2026
rubenhoenle
reviewed
Nov 9, 2026
rubenhoenle
reviewed
Nov 9, 2026
rubenhoenle
reviewed
Nov 9, 2026
rubenhoenle
reviewed
Nov 9, 2026
| } | ||
|
|
||
| func TestBuildRequest(t *testing.T) { | ||
| keyring.MockInit() |
Member
There was a problem hiding this comment.
Same as below, use the mock client implementation from the SDK instead
Author
There was a problem hiding this comment.
With the keyring mock I don't know, it seems that is the way to go actually...
There is no interface and no mock for the auth, if I want to test auth.GetAuthEmail() branch
Are there any examples for alternative mocking of this path?
So far, I mimic the existing tests
rubenhoenle
reviewed
Nov 9, 2026
mszadkow
force-pushed
the
feat/add-folder-command
branch
from
November 12, 2026 16:11
0f0f70c to
a2c52a4
Compare
mszadkow
marked this pull request as ready for review
November 12, 2026 16:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partially onboard
foldercommand as for internal purposes only folder information retrieval is required.relates to #1736
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)