Repository navigation
feat(telemetryrouter): partial TelemetryRouter update waiter - #13297
Open
ozanichkovsky wants to merge 4 commits into
Open
ozanichkovsky wants to merge 4 commits into
ozanichkovsky wants to merge 4 commits into
Conversation
Fyusel
reviewed
Oct 27, 2026
| Filter *ConfigFilter `json:"filter,omitempty"` | ||
| DisplayName *string `json:"displayName,omitempty" validate:"regexp=^[a-zA-Z0-9][a-zA-Z0-9 \\-]*$"` | ||
| Filter *ConfigFilter `json:"filter,omitempty"` | ||
| ResourceLabels *map[string]string `json:"resourceLabels,omitempty"` |
Contributor
There was a problem hiding this comment.
The ResourceLabels were added as well. This should be covered in the changelog.
| // ConfigFilterAttributes struct for ConfigFilterAttributes | ||
| type ConfigFilterAttributes struct { | ||
| Key string `json:"key"` | ||
| Key string `json:"key" validate:"regexp=^[^\\0-\\x1F\\x7F-\\x9F]+$"` |
Contributor
There was a problem hiding this comment.
Here a validation was added which should be mentioned in the changelog as well (breaking change)
| BasicAuth *DestinationConfigOpenTelemetryBasicAuth `json:"basicAuth,omitempty"` | ||
| // A bearer token to authenticate at the OpenTelemetry URI. | ||
| BearerToken *string `json:"bearerToken,omitempty"` | ||
| BearerToken *string `json:"bearerToken,omitempty" validate:"regexp=^[^\\0-\\x1F\\x7F-\\x9F]+$"` |
| BearerToken *string `json:"bearerToken,omitempty" validate:"regexp=^[^\\0-\\x1F\\x7F-\\x9F]+$"` | ||
| // The URI for reaching the resource. | ||
| Uri string `json:"uri"` | ||
| Uri string `json:"uri" validate:"regexp=^[^\\0-\\x1F\\x7F-\\x9F]+$"` |
| Password string `json:"password"` | ||
| Username string `json:"username"` | ||
| Password string `json:"password" validate:"regexp=^[^\\0-\\x1F\\x7F-\\x9F]+$"` | ||
| Username string `json:"username" validate:"regexp=^[^\\0-\\x1F\\x7F-\\x9F]+$"` |
| Bucket string `json:"bucket" validate:"regexp=^[a-z0-9\\-]+$"` | ||
| // The URI for reaching the resource. | ||
| Endpoint string `json:"endpoint"` | ||
| Endpoint string `json:"endpoint" validate:"regexp=^[^\\0-\\x1F\\x7F-\\x9F]+$"` |
| Id string `json:"id"` | ||
| Secret string `json:"secret"` | ||
| Id string `json:"id" validate:"regexp=^[^\\0-\\x1F\\x7F-\\x9F]+$"` | ||
| Secret string `json:"secret" validate:"regexp=^[^\\0-\\x1F\\x7F-\\x9F]+$"` |
| // The description is a longer text chosen by the user to provide more context for the resource. | ||
| Description *string `json:"description,omitempty" validate:"regexp=^([a-zA-Z0-9][a-zA-Z0-9 \\-]*)?$"` | ||
| // The number of destinations configured for the telemetry router. | ||
| DestinationCount *int32 `json:"destinationCount,omitempty"` |
Contributor
There was a problem hiding this comment.
This field is new as well, which should be mentioned in the changelog
Co-authored-by: Alexander Dahmen <dahmena_hws@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds waiter for the new PartialUpdateTelemetryRouter operation
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)