-
Notifications
You must be signed in to change notification settings - Fork 2
Strengthen docs-review skill and codify closing section pattern #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -141,9 +141,15 @@ Not every section needs every phase. The Introduction is an explicit first sideb | |||||||||||||||||
| Every how-to guide and tutorial page must include: | ||||||||||||||||||
|
|
||||||||||||||||||
| - Front matter with `title` and `description`. | ||||||||||||||||||
| - A "Next steps" section at the end with 1-3 links to the next logical pages, following the journey phases (install, use, secure, operate, optimize). | ||||||||||||||||||
| - A "Next steps" section with 1-3 links to the next logical pages, following the journey phases (install, use, secure, operate, optimize). | ||||||||||||||||||
| - Cross-links to related content in other sections where relevant. | ||||||||||||||||||
|
|
||||||||||||||||||
| Pages that include closing sections must use this ordering: | ||||||||||||||||||
|
Comment on lines
+144
to
+147
|
||||||||||||||||||
| - A "Next steps" section with 1-3 links to the next logical pages, following the journey phases (install, use, secure, operate, optimize). | |
| - Cross-links to related content in other sections where relevant. | |
| Pages that include closing sections must use this ordering: | |
| - A `## Next steps` section at the end of the page, with 1-3 links to the next logical pages, following the journey phases (install, use, secure, operate, optimize). | |
| - Cross-links to related content in other sections where relevant. | |
| Pages that include closing sections must use this ordering, as consecutive `##`-level headings at the end of the page: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The “Placeholder examples” guidance calls out
my-skill/example-org/my-appas undesirable, which makes sense, but the skill doesn’t mention the project’s established placeholder convention (<ALL_CAPS>in STYLE-GUIDE.md:89 and AGENTS.md:181). Consider adding a note that when placeholders are unavoidable (user/org names, paths, tokens), reviewers should prefer<ALL_CAPS>placeholders rather than pseudo-realmy-*values.