RFC: Shared key authentication for local MCP servers#16
Open
Conversation
Port proposal from toolhive PR #2570. This RFC proposes a lightweight authentication mechanism for localhost MCP server deployments using cryptographically-secure shared keys stored in the OS keychain. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
eleftherias
reviewed
Mar 26, 2026
Member
eleftherias
left a comment
There was a problem hiding this comment.
This approach makes sense, but I wonder if it could be simplified.
Did you also consider a single shared key across workloads?
The proposal states
Key injected via
TOOLHIVE_SHARED_KEYenvironment variable to container and proxy
But does the container need to know the key?
I assume if the container doesn't know the key, then we can use a single key across all workloads without risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port proposal from toolhive PR #2570.
This proposal introduces a lightweight authentication mechanism for localhost MCP server deployments that provides defense-in-depth security without requiring external identity providers.
Overview
The proposal adds shared key authentication as an opt-in feature for local ToolHive deployments. While localhost binding provides network-level security, this adds an additional authentication layer for defense-in-depth.
Key Features
thv proxy stdiobridge--shared-key-authflagArchitecture
The solution leverages existing ToolHive infrastructure:
Security Properties
crypto/randUsage Example