Support Embedded Auth Server alongside AWS STS token exchange#50
Merged
tgrunnagle merged 4 commits intomainfrom Apr 7, 2026
Merged
Support Embedded Auth Server alongside AWS STS token exchange#50tgrunnagle merged 4 commits intomainfrom
tgrunnagle merged 4 commits intomainfrom
Conversation
jhrozek
reviewed
Mar 9, 2026
jhrozek
previously approved these changes
Apr 7, 2026
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
I think it would be nice to reframe the top-level proposal and problem introduction so that it's clear the RFC is not just about AWS STS and perhaps use a more generic and extensible way of referring to the external auth config. But neither needs to be done now, I'm acking the RFC so you can merge and go forward if you feel like these are too nitty,
- use `TypedLocalObjectReference` - generalize RFC to be about "dedicated auth server reference" - add e2e tests implementation phase
jhrozek
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC to support running the embedded authorization server alongside the AWS STS token exchange middleware.