Skip to content

Swap to concurrency groups instead of a step #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgabry merged 1 commit into from
Feb 24, 2026
Merged

Swap to concurrency groups instead of a step #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/R-CMD-check-wsl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ name: Unit tests - WSL Backend
branches:
- master

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
WSL-R-CMD-check:
if: "! contains(github.event.head_commit.message, '[ci skip]')"
Expand All @@ -31,11 +35,6 @@ jobs:
echo "CMDSTAN_PATH=${HOME}/.cmdstan" >> $GITHUB_ENV
shell: bash

- uses: n1hility/cancel-previous-runs@v3
with:
token: ${{ secrets.GITHUB_TOKEN }}
if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/master'"

- uses: actions/checkout@v6

- uses: r-lib/actions/setup-r@v2
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ name: Unit tests
required: false
default: ''

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new concurrency configuration changes behavior compared to the previous cancel-previous-runs step. The old step excluded master branch pushes from cancellation (github.ref != 'refs/heads/master'), but the new concurrency group will cancel in-progress runs even for master branch pushes. If you want to preserve the old behavior and prevent cancellation on master, you could use a conditional concurrency configuration or adjust the group pattern to ensure master branch runs are not cancelled.

Suggested change
cancel-in-progress: true
cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}

Copilot uses AI. Check for mistakes.
Copy link
Member

@jgabry jgabry Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new behavior is OK


jobs:
R-CMD-check:
if: "! contains(github.event.head_commit.message, '[ci skip]')"
Expand Down Expand Up @@ -51,11 +55,6 @@ jobs:
echo "CMDSTAN_PATH=${HOME}/.cmdstan" >> $GITHUB_ENV
shell: bash

- uses: n1hility/cancel-previous-runs@v3
with:
token: ${{ secrets.GITHUB_TOKEN }}
if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/master'"

- uses: actions/checkout@v6

- uses: r-lib/actions/setup-r@v2
Expand Down