Fix the default language style for newly created code blocks#2999
Merged
Conversation
Contributor
Author
|
May I ask, as paying customers, specifically "Professional" ones, how long could we expect our contributions to get responded from the team? |
Contributor
|
Hi @micl2e2! Thank you for your contribution, changes look good. Apologies for the delay in reviewing your PR 🙏 we try to review all contributor PRs as soon as possible, but response times can vary depending on the team's current priorities and workload. We appreciate your patience and your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that most code in
CodeOptions.tsxthat tries to set default language as 'empty' provides little help, and somehow always fallback to JS (https://github.com/facebook/lexical/blob/5dd93a7c8b4b23d2b00a547c2d860cb17aed1e52/packages/lexical-code-core/src/CodeNode.ts#L52).I marked this as a "fix" is because line 18 suggests that the plain text type was needed at the very beginning.