[6.x] Make Files fieldtype temporary upload storage configurable#14733
Merged
Conversation
This was referenced May 27, 2026
Contributor
|
Awesome, thanks so much! This should work nicely with Livewire Forms |
Splits the nested file_uploads.disk/path config into top-level file_uploads_disk and file_uploads_path settings, matching the flat key convention used elsewhere in config/system.php. Keeping disk and path as distinct top-level keys also makes it easier for other kinds of temporary uploads (e.g. forms) to reuse the same disk via their own dedicated path setting. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Covers the write path (FileUploader via the Files fieldtype upload route), the DeleteTemporaryFileUploads cleanup middleware, and the DeleteTemporaryAttachments form job, asserting each respects the file_uploads_disk/file_uploads_path config instead of the hardcoded local disk and statamic/file-uploads path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes the Files fieldtype's temporary upload storage configurable, allowing files to be stored on a shared filesystem for multi-server environments.
Previously, temporary file uploads were hardcoded to use the
localdisk atstatamic/file-uploads. This caused issues in multi-server setups where a file might be uploaded on one server but processed (e.g., queued form emails with attachments) on another.This PR adds two new config options in
config/system.php:These can be configured via environment variables to use a shared filesystem like S3:
This PR also adds a test to verify the configured disk is used.
Requested on Twitter: https://x.com/adampatterson/status/2057113369623298060