[6.x] Forms 2: Various file upload improvements#15006
Draft
duncanmcclean wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes various improvements to how File Uploads are handled in Forms.
Upload fieldtype
This PR adds a new Upload fieldtype, designed to better facilitate file uploads on forms.
Previously, the Upload form fieldtype resolved to either the
assets/filesfieldtypes, depending on whether the uploaded file should be stored or not.This worked great — until we started building automagic form pages in Forms Pro, which reuses fieldtype Vue components. The
assetsandfilesfieldtypes had different UIs, which was a little confusing, but they also hit/cpURLs which require authentication (something a visitor filling out a form obviously doesn't have).FormUploadFieldtype.vuehas two states:filesfieldtype. Instead of uploading files the moment they're added, they're uploaded when the page is submitted. This is the state used on the Automagic Form page.Form::convertFieldsFromBlueprint()already migratesassets/filesfields to the Upload form fieldtype when converting a traditional blueprint to Forms 2. However, we still need to support bareassets/filesfields directly, since fields brought in via a fieldset import use their real, underlying fieldtype, rather than going through a "form fieldtype".