Skip to content

Chore/fix javascript lint errors issue 11750#11783

Closed
GuneetGill wants to merge 3 commits intostdlib-js:developfrom
GuneetGill:chore/fix-javascript-lint-errors-issue-11750
Closed

Chore/fix javascript lint errors issue 11750#11783
GuneetGill wants to merge 3 commits intostdlib-js:developfrom
GuneetGill:chore/fix-javascript-lint-errors-issue-11750

Conversation

@GuneetGill
Copy link
Copy Markdown
Contributor

@GuneetGill GuneetGill commented Apr 25, 2026

Resolves #11750.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes JavaScript lint failures in lib/node_modules/@stdlib/stats/kstest/test/test.marsaglia.js by updating array formatting to satisfy array-element-newline and removing now-unneeded eslint-disable-line directives.
  • Adds targeted ESLint suppression for no-restricted-syntax on the tape callback function expressions used in this test file.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-js/reviewers

@GuneetGill GuneetGill requested a review from a team April 25, 2026 23:31
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Apr 25, 2026
@GuneetGill
chore: fix JavaScript lint errors (issue stdlib-js#11750)
bd093bd 
Made-with: Cursor

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@GuneetGill GuneetGill force-pushed the chore/fix-javascript-lint-errors-issue-11750 branch from f052a19 to bd093bd Compare April 25, 2026 23:33
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Apr 25, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 25, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/kstest $\color{green}885/885$
$\color{green}+0.00%$ 		$\color{green}128/128$
$\color{green}+0.00%$ 		$\color{green}10/10$
$\color{green}+0.00%$ 		$\color{green}885/885$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@GuneetGill
chore: fix JavaScript lint errors (issue stdlib-js#11750)
c2cb086 
Made-with: Cursor

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@GuneetGill
chore: suppress lint rule in kstest test (issue stdlib-js#11750)
65c3260 
Made-with: Cursor

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 27, 2026

Ref: #11794

@kgryte kgryte added autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. and removed Needs Review A pull request which needs code review. labels Apr 27, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 27, 2026

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants

@GuneetGill @stdlib-bot @kgryte